Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompty: improve token count estimation #3821

Closed
wants to merge 2 commits into from
Closed

prompty: improve token count estimation #3821

wants to merge 2 commits into from

Conversation

ianchi
Copy link
Contributor

@ianchi ianchi commented Oct 19, 2024 •
edited
Loading

Description

Current token count estimation is incomplete.
This PR adds tools definitions and tool calls into the computation, and allows to define a valid OpenAI model name to use to determine the tokenizer, which is needed in case of Azure OpenAI when the deployment is not a valid OpenAI model name.

Fixes #3809.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ianchi
prompty: improve token count estimation
e6b576f 
Adds tools definitions and tool calls into the computation
@ianchi ianchi requested a review from a team as a code owner October 19, 2024 03:31
@ianchi
prompty: allow to override openai model for token count
9f047c7 
This is needed for AzureOpenAI models where the deployment name is not a valid OpenAI model.
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Nov 2, 2024
@ianchi
Copy link
Contributor Author

ianchi commented Nov 8, 2024

Hi, any chance to advance with this?

@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue/pull request label Nov 8, 2024
@github-actions GitHub Actions
Copy link

SDK CLI Global Config Test Result tokens

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9f047c7.

@github-actions GitHub Actions
Copy link

Executor E2E Test Result tokens

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9f047c7.

@github-actions GitHub Actions
Copy link

Executor Unit Test Result tokens

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9f047c7.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
external no-recent-activity There has been no recent activity on this issue/pull request promptflow-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Bad token estimation in Prompty
1 participant
@ianchi